Skip to content

feat: add blas/ext/base/capx#12239

Merged
kgryte merged 17 commits into
stdlib-js:developfrom
anandkaranubc:feat/capx
May 24, 2026
Merged

feat: add blas/ext/base/capx#12239
kgryte merged 17 commits into
stdlib-js:developfrom
anandkaranubc:feat/capx

Conversation

@anandkaranubc
Copy link
Copy Markdown
Contributor

@anandkaranubc anandkaranubc commented May 22, 2026

Progresses stdlib-js/metr-issue-tracker#632

Description

What is the purpose of this pull request?

This pull request:

  • adds blas/ext/base/saxpb

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Cursor+VS Code code-generation tools to help assist with the feature.

@stdlib-js/reviewers

iampratik13 and others added 8 commits May 18, 2026 00:28
@iampratik13
feat: add lapack/base/dlaisnan
21290f0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
chore: update copyright years
4f70f76
@iampratik13
chore: suggested changes
9e4bf55 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
Merge branch 'develop' into lapack/dlaisnan
ffadd3b
@anandkaranubc
chore: remove redundant keyword
f579524 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
docs: keep consistent examples across files
8fac49a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
Merge branch 'develop' into feat/capx
521832f
@anandkaranubc
feat: add blas/ext/base/capx
63f316b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc requested a review from a team May 22, 2026 06:29
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 22, 2026
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label May 22, 2026
@anandkaranubc anandkaranubc added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. METR Pull request associated with the METR project. labels May 22, 2026
@anandkaranubc anandkaranubc requested a review from kgryte May 22, 2026 06:32
@anandkaranubc
Copy link
Copy Markdown
Contributor Author

anandkaranubc commented May 22, 2026

It took me so long to implement this haha 💀

If I could go back in time, I wouldn’t have started implementing it with AI.

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 22, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/capx $\color{green}441/441$
$\color{green}+0.00%$ 		$\color{green}29/29$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}441/441$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Copy link
Copy Markdown
Contributor Author

anandkaranubc commented May 22, 2026

CI failure is unrelated.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 24, 2026
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/benchmark/benchmark.js Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/benchmark/benchmark.js Outdated
@kgryte
Apply suggestions from code review
18a084a 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/docs/repl.txt Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/docs/repl.txt Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/examples/index.js Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/lib/ndarray.js Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/src/main.c Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/src/main.c Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/test/test.capx.js Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/test/test.capx.js Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/test/test.capx.js
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/test/test.capx.native.js Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/README.md Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/README.md Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/README.md Outdated
kgryte
kgryte requested changes May 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 24, 2026

@anandkaranubc I don't think the CI failure is actually a fluke. I think there is something wrong with your package. It is likely due to various buffer overflow issues in your examples. Get those cleaned up and we'll see if the issue persists.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label May 24, 2026
@anandkaranubc
Merge branch 'develop' into feat/capx
fd881ce
@anandkaranubc
chore: apply suggestions from review
3929792 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
docs: fix example
fb27d5f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/lib/ndarray.native.js Outdated
@kgryte
Apply suggestions from code review
0bcc5ef 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/README.md Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/README.md Outdated
kgryte
kgryte reviewed May 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/capx/README.md Outdated
@kgryte
Apply suggestions from code review
8ae4af6 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes May 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some more clean-up.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label May 24, 2026
@kgryte kgryte merged commit ce17493 into stdlib-js:develop May 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anandkaranubc @stdlib-bot @kgryte @iampratik13